Included the following record types: calcout, int64in, int64out, lsi …#30
Included the following record types: calcout, int64in, int64out, lsi …#30andrewstarritt wants to merge 1 commit intoepics-modules:masterfrom
Conversation
| device(int64in, INST_IO, pydevsupComIn, "Python Device") | ||
| device(int64out, INST_IO, pydevsupComOut, "Python Device") | ||
|
|
||
| device(lsi, INST_IO, pydevsupComIn, "Python Device") | ||
| device(lso, INST_IO, pydevsupComOut, "Python Device") |
There was a problem hiding this comment.
Use of these record types needs needs to be conditional on epics-base version.
- lsi & lso: >= 3.15.0.2
- int64in && int64out: >= 3.16.1
EPICS_VERSION and friends are already imported into this file.
Also, if you are willing. @pheest has pointed out that my usage of NamedTemporaryFile() does not work on Windows. He suggested replacing usage of NamedTemporaryFile() with one or more static .dbd files installed alongside this __init__.py and loaded using a path computed from __file__. This could be combined, or a separate change.
There was a problem hiding this comment.
To be precise, what didn't work on Windows was opening the file for both write and read.
I resolved the issue by opening the file for write, closing it, re-opening it for read, then deleted it.
But since the file doesn't appear to have any variable content, I don't think there is a reason to use a temporary file.
|
I have attempted to use the lsi data type, but I could not get this to work. |
|
I have the lsi type working.
|
…and lso.
Impacted file: devsupApp/src/devsup/init.py
All worked when I tested on my system: rocky 8 using base-7.0.7